Skip to content

Commit

Permalink
#0: Revert "Publish Release Images (#15013)" because docker image nam…
Browse files Browse the repository at this point in the history
…e is not

    being passed properly for release image

This reverts commit 845ddf8.
  • Loading branch information
tt-rkim committed Nov 26, 2024
1 parent 74fe7d1 commit 364e3fd
Show file tree
Hide file tree
Showing 11 changed files with 37 additions and 181 deletions.
2 changes: 1 addition & 1 deletion .github/actions/docker-run/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ runs:
${{ inputs.device }}
-w ${{ github.workspace }}
run: |
if [ "${{ inputs.install_wheel }}" == "true" ]; then
if [ ${{ inputs.install_wheel }} ]; then
WHEEL_FILENAME=$(ls -1 *.whl)
pip3 install $WHEEL_FILENAME
fi
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/generate-docker-tag/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ runs:
- name: Determine Full Docker Image Tag
shell: bash
run: |
echo "TT_METAL_DOCKER_IMAGE_TAG=ghcr.io/${{ github.repository }}/${{ inputs.image }}:${{ env.IMAGE_TAG }}" >> $GITHUB_ENV
echo "TT_METAL_REF_IMAGE_TAG=ghcr.io/${{ github.repository }}/${{ inputs.image }}:latest" >> $GITHUB_ENV
echo "TT_METAL_DOCKER_IMAGE_TAG=ghcr.io/${{ github.repository }}/tt-metalium/${{ inputs.image }}:${{ env.IMAGE_TAG }}" >> $GITHUB_ENV
echo "TT_METAL_REF_IMAGE_TAG=ghcr.io/${{ github.repository }}/tt-metalium/${{ inputs.image }}:latest" >> $GITHUB_ENV
- name: Output Docker Image Tag
shell: bash
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-artifact.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ jobs:
id: generate-docker-tag
uses: ./.github/actions/generate-docker-tag
with:
image: tt-metalium/${{ inputs.os }}
image: ${{ inputs.os }}
- name: Docker login
uses: docker/login-action@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-docker-artifact.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
- name: Determine docker image tag
uses: ./.github/actions/generate-docker-tag
with:
image: tt-metalium/${{ inputs.os }}
image: ${{ inputs.os }}
- name: Build Docker image and push to GHCR
if: steps.changed-files-specific.outputs.any_changed == 'true'
uses: docker/build-push-action@v6
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/code-analysis.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
id: generate-docker-tag
uses: ./.github/actions/generate-docker-tag
with:
image: tt-metalium/${{ inputs.os }}
image: ${{ inputs.os }}
- name: Docker login
uses: docker/login-action@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cpp-ttnn-project.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
id: generate-docker-tag
uses: ./.github/actions/generate-docker-tag
with:
image: tt-metalium/ubuntu-22.04-amd64
image: ubuntu-22.04-amd64
- name: Docker login
uses: docker/login-action@v3
with:
Expand Down
26 changes: 21 additions & 5 deletions .github/workflows/package-and-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,27 @@ jobs:
create-tag,
create-and-upload-draft-release
]
uses: ./.github/workflows/publish-release-image.yaml
secrets: inherit
with:
version: ${{ needs.create-tag.outputs.version }}
is_major_version: ${{ needs.get-params.outputs.is-release-candidate !='true' && needs.get-params.outputs.should-create-release == 'true' }}
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Login to GitHub Container Registry
uses: docker/login-action@v3
with:
registry: https://ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Build and push
env:
TT_METAL_DOCKER_IMAGE: tt-metalium/ubuntu-20.04-amd64
uses: docker/build-push-action@v6
with:
push: true
tags: ghcr.io/${{ github.repository }}/tt-metalium/ubuntu-20.04-amd64:${{ needs.create-tag.outputs.version }}-dev
context: .
file: dockerfile/ubuntu-20.04-amd64.Dockerfile
release-docs:
needs: [
get-params,
Expand Down
34 changes: 7 additions & 27 deletions .github/workflows/publish-release-image-wrapper.yaml
Original file line number Diff line number Diff line change
@@ -1,32 +1,12 @@
name: "Create and Publish Release Docker Image"

on:
workflow_call:
workflow_dispatch:

jobs:
static-checks:
uses: ./.github/workflows/all-static-checks.yaml
secrets: inherit
build-artifact:
needs: static-checks
uses: ./.github/workflows/build-artifact.yaml
secrets: inherit
build-wheels:
needs: build-artifact
strategy:
matrix:
# Since pre-compiled builds only run on 20.04, we can only test on 20.04 for now
# The full 22.04 flow can be tested without precompiled
os: [ubuntu-20.04]
arch: [grayskull, wormhole_b0]
uses: ./.github/workflows/_build-wheels-impl.yaml
with:
os: ${{ matrix.os }}
arch: ${{ matrix.arch }}
from-precompiled: true
publish-release-image:
needs: build-wheels
uses: ./.github/workflows/publish-release-image.yaml
secrets: inherit
with:
version: dev-${GITHUB_REF_NAME//\//-}
is_major_version: false
to_be_filled_out:
steps:
- name: This workflow will be filled out in https://github.com/tenstorrent/tt-metal/pull/15013
run: |
echo "NOOP"
111 changes: 0 additions & 111 deletions .github/workflows/publish-release-image.yaml

This file was deleted.

23 changes: 2 additions & 21 deletions INSTALLING.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,14 @@ sudo -E python3 setup_hugepages.py enable && sudo -E python3 setup_hugepages.py

> [!NOTE]
>
> You may choose to install from either source, a Python wheel, or Docker release image.
> You may choose to install from either source or a Python wheel.
>
> However, no matter your method, in order to use our pre-built models or to
> follow along with the documentation and tutorials to get started, you will
> still need the source code.
>
> If you do not want to use the models or follow the tutorials and want to
> immediately start using the API, you may install just the wheel or get the release Docker container.
> immediately start using the API, you may install just the wheel.
1. Install git and git-lfs.

Expand Down Expand Up @@ -157,25 +157,6 @@ sudo apt-get install cpufrequtils
sudo cpupower frequency-set -g performance
```

### Option 3: From Docker Release Image

Download the latest Docker release from our
[releases](https://github.com/tenstorrent/tt-metal/releases/latest) page for
the particular Tenstorrent card architecture that you have installed on your
system. (ie. Grayskull, Wormhole, etc)

```sh
docker pull ghcr.io/tenstorrent/tt-metal/tt-metalium-ubuntu-20.04-amd64-release/<arch_name>:latest
docker run --it --rm -v /dev/hugepages-1G:/dev/hugepages-1G --device /dev/tenstorrent ghcr.io/tenstorrent/tt-metal/tt-metalium-ubuntu-20.04-amd64-release/<arch_name>:latest bash
```
where `arch_name` is one of `grayskull`, `wormhole_b0`, or `blackhole`,
depending on your Tenstorrent card type.

When inside of the container,
```sh
python3 -c "import ttnn"
```

5. Start coding

To verify your installation, try the executing an example:
Expand Down
10 changes: 0 additions & 10 deletions dockerfile/release.Dockerfile

This file was deleted.

0 comments on commit 364e3fd

Please sign in to comment.