#8280: add ninja as a metal dependency as builds are faster with ninj…

…a (5-15%)
tenstorrent · May 13, 2024 · 12f958b · 12f958b
1 parent 67067db
commit 12f958b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/.github/actions/install-metal-dev-deps/dependencies.json b/.github/actions/install-metal-dev-deps/dependencies.json
@@ -7,14 +7,16 @@
     "pandoc",
     "libtbb-dev",
     "libcapstone-dev",
-    "pkg-config"
+    "pkg-config",
+    "ninja-build"
   ],
   "ubuntu-22.04": [
     "git",
     "git-lfs",
     "pandoc",
     "libtbb-dev",
     "libcapstone-dev",
-    "pkg-config"
+    "pkg-config",
+    "ninja-build"
   ]
 }
diff --git a/INSTALLING.md b/INSTALLING.md
@@ -119,7 +119,7 @@ Please follow the next additional steps if you want to contribute to the codebas
 1. Install dependencies
 
 ```sh
-sudo apt install clang-6.0=1:6.0.1-14 git git-lfs cmake=3.16.3-1ubuntu1.20.04.1 pandoc libtbb-dev libcapstone-dev pkg-config
+sudo apt install clang-6.0=1:6.0.1-14 git git-lfs cmake=3.16.3-1ubuntu1.20.04.1 pandoc libtbb-dev libcapstone-dev pkg-config ninja-build
 ```
 
 2. Download and install [Doxygen](https://www.doxygen.nl/download.html), (v1.9 or higher, but less than v1.10)

diff --git a/build_metal.sh b/build_metal.sh
@@ -18,8 +18,8 @@ else
 fi
 
 echo "Building tt-metal"
-cmake -B build
-cmake --build build -- -j`nproc`
+cmake -B build -G Ninja
+cmake --build build
 cmake --build build --target metal-install
 
 echo "Creating virtual env in: $PYTHON_ENV_DIR"