Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try converting aten.argmax #235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Try converting aten.argmax #235

wants to merge 1 commit into from

Conversation

jdh8
Copy link
Collaborator

@jdh8 jdh8 commented Sep 19, 2024

Ticket

None

Problem description

In the beginning, ttnn.argmax requests row-major layout.

E       RuntimeError: TT_FATAL @ /home/jdh8/tt-metal/ttnn/cpp/ttnn/operations/reduction/argmax/device/argmax_op.cpp:19: input_tensor_a.get_layout() == Layout::ROW_MAJOR
E       info:
E       Only ROW_MAJOR layout is supported for inputs!

Then I convert the input tensor to row-major layout, but it complains

RuntimeError: TT_FATAL @ /home/jdh8/tt-metal/ttnn/cpp/ttnn/operations/reduction/argmax/device/argmax_op.cpp:46: input_shape[1]==1

What's changed

  • Convert aten.argmax to ttnn.argmax

In the beginning, `ttnn.argmax` requests row-major layout.
```
E       RuntimeError: TT_FATAL @ /home/jdh8/tt-metal/ttnn/cpp/ttnn/operations/reduction/argmax/device/argmax_op.cpp:19: input_tensor_a.get_layout() == Layout::ROW_MAJOR
E       info:
E       Only ROW_MAJOR layout is supported for inputs!
```

Then I convert the input tensor to row-major layout, but it complains
```
RuntimeError: TT_FATAL @ /home/jdh8/tt-metal/ttnn/cpp/ttnn/operations/reduction/argmax/device/argmax_op.cpp:46: input_shape[1]==1
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant