Convert aten.alias to no-op
#223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrysky3
force-pushed
the
feature/alias
branch
from
f5abb9a to
51c561f
Compare
jdh8
approved these changes
Sep 19, 2024
| @@ -312,6 +312,10 @@ def call_function(self, target, args, kwargs): | |||
| return self.call_function_prop_meta(ttnn.squeeze, args, kwargs) | |||
| return self.call_function_prop_meta(target, args, kwargs) | |||
|
|
|||
| if target == torch.ops.aten.alias.default: | |||
| # alias is no-op | |||
| return args[0] | |||
There was a problem hiding this comment.
Amazing discovery! Since directly returning an argument is a valid conversion, this can lead to several simplifications:
- We can refactor manual conversions to simple conversions, e.g.
aten.arange.*→ttnn.arange. - Perhaps we can optimize out
aten.clonelikeaten.alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
No
Problem description
Convert
aten.aliasto no-opWhat's changed
aten.aliaswith its input (no-op)