Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the docstring of Differentiator.differentiate_analytic #808

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

majafranz
Copy link
Contributor

Changes

Fixed a typo in the differentiator.Differentiator.differentiate_analytic docstring.
"... calls he inheriting ..." got changed into "... calls the inheriting ..."

Copy link

google-cla bot commented Apr 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mhucka mhucka added area/docs Concerns documentation – problems, ideas, requests cla: no A Google Contributor License Agreement (CLA) is not on file for the author labels Dec 2, 2024
@mhucka
Copy link
Member

mhucka commented Dec 4, 2024

@majafranz Thanks for catching this. I'd be happy to merge it, but (as silly as it seems for such a small pull request) we are required to get a contributor license agreement from all contributors before we can accept contributions. Would you be willing and able to fill out the CLA form? (See the bot's comment higher ↑ on this page.)

@majafranz
Copy link
Contributor Author

@majafranz Thanks for catching this. I'd be happy to merge it, but (as silly as it seems for such a small pull request) we are required to get a contributor license agreement from all contributors before we can accept contributions. Would you be willing and able to fill out the CLA form? (See the bot's comment higher ↑ on this page.)

Hi, I think I have already filled in the form. Maybe it needs to be checked again?
Anyway, as this PR only fixes a typo, I would not be too upset if it was not merged :)

@google-cla google-cla bot added cla: yes A Google Contributor License Agreement (CLA) is on file for the author and removed cla: no A Google Contributor License Agreement (CLA) is not on file for the author labels Dec 6, 2024
@mhucka
Copy link
Member

mhucka commented Dec 6, 2024

Hi, I think I have already filled in the form. Maybe it needs to be checked again?

Thanks for letting me know. I re-ran the check and it passed this time!

@mhucka mhucka self-requested a review December 9, 2024 15:49
Copy link
Member

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mhucka mhucka merged commit 8487280 into tensorflow:master Dec 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Concerns documentation – problems, ideas, requests cla: yes A Google Contributor License Agreement (CLA) is on file for the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants