Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ArrayType(StringType, _) for SequenceExample #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhangxuhong
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@zhangxuhong
Copy link
Author

i signed

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jhseu
Copy link
Contributor

jhseu commented Jun 20, 2019

@skavulya Would you mind taking a look if you have time?

@zhangxuhong Mind adding a test?

@zhangxuhong
Copy link
Author

@jhseu Thanks for taking a look at it. If this issue can be confirmed, i will add the corresponding tests.

@skavulya
Copy link
Contributor

@zhangxuhong Thanks for the contribution. I'll take a look at it this evening to confirm the issue.

@skavulya
Copy link
Contributor

@zhangxuhong Yes, this is an issue. Please add the unit tests. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants