Keras basic text classification tutorial: removed +1 from embeddings …

[vaharoni]

…input dimensions

In the Tutorials > Beginner > ML basics with Keras > Basic text classification, there is the following code:

max_features = 10000
sequence_length = 250

vectorize_layer = layers.TextVectorization(
    standardize=custom_standardization,
    max_tokens=max_features,
    output_mode='int',
    output_sequence_length=sequence_length)

# ...

model = tf.keras.Sequential([
  layers.Embedding(max_features + 1, embedding_dim),
  layers.Dropout(0.2),
  layers.GlobalAveragePooling1D(),
  layers.Dropout(0.2),
  layers.Dense(1)])

I believe the +1 in max_features + 1 is unnecessary, as the vocabulary of TextVectorization layers already includes the padding and OOV tokens.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Preview

Preview and run these notebook edits with Google Colab:

• site/en/tutorials/keras/text_classification.ipynb

Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:

$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb

$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb

If commits are added to the pull request, synchronize your local branch: git pull origin vaharoni/text-classification-fix

[8bitmp3]

@MarkDaoust

[8bitmp3]

@vaharoni Thanks again for the PR. Can you check the cla/google link below and sign the CLA is you haven't done so already https://github.com/tensorflow/docs/actions/runs/5977063575/job/16982580897?pr=2256

[vaharoni]

I have already signed the CLA, and this was picked up correctly on a different PR I made. When I visit the CLA page, it says "It looks like you've already signed this CLA. If you'd like to edit your contact information, you may do so below." I clicked on "I agree" again nevertheless. Let me know if you need me to do anything else.

[MarkDaoust]

@google-cla try again

[MarkDaoust]

Sorry about the delay, we should be good to go now.