feat: add envd app exit handler (#1722)

* feat: add envd app exit handler Signed-off-by: Keming <[email protected]> * rm commented code Signed-off-by: Keming <[email protected]> * fix test Signed-off-by: Keming <[email protected]> --------- Signed-off-by: Keming <[email protected]>
tensorchord · Aug 4, 2023 · f51990e · f51990e
1 parent ddc3009
commit f51990e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/pkg/app/app.go b/pkg/app/app.go
@@ -155,6 +155,12 @@ func New() EnvdApp {
 		return nil
 	}
 
+	internalApp.ExitErrHandler = func(context *cli.Context, err error) {
+		if err != nil {
+			logrus.Fatal(err)
+		}
+	}
+
 	return EnvdApp{
 		App: *internalApp,
 	}

diff --git a/pkg/driver/docker/docker.go b/pkg/driver/docker/docker.go
@@ -96,7 +96,11 @@ func NormalizeName(s string) (string, error) {
 	}
 	// remove the spaces
 	s = strings.ReplaceAll(s, " ", "")
-	return s, nil
+	name, err := reference.Parse(s)
+	if err != nil {
+		return "", errors.Wrapf(err, "failed to parse the name '%s', please provide a valid image name", s)
+	}
+	return name.String(), nil
 }
 
 func (c dockerClient) ListImage(ctx context.Context) ([]types.ImageSummary, error) {