This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
cosmos-stdtx.rs: amino serializer for Cosmos SDK-formatted StdTx transactions #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial crate boilerplate + schema types (and TOML definition language) for describing `sdk.Msg` types.
Support for programatically building messages from fields and values, validating them against the schema, and encoding the resulting messages as Amino.
The schema-based encoder is only for `Msg`. This adds a `StdTx` type using `prost-amino-derive` to programatically declare it.
tarcieri
force-pushed
the
cosmos-stdtx
branch
from
7e1382f to
be27fdf
Compare
This commit contains the initial implementation of the `stdtx::Builder` type with support for constructing, signing, and serializing `StdTx` messages as Amino bytes. Also includes a comprehensive usage example for how to build a real-world transaction.
tarcieri
changed the title
|
Initial functionality is in place and confirmed working, so I'm going to go ahead and merge. There's a few small things I'd like to fix up before an initial release, however. |
tarcieri
pushed a commit
to iqlusioninc/crates
that referenced
this pull request
Jan 27, 2020
Originally developed here as the `cosmos-stdtx` crate: tendermint/tmkms#401 This imports the code, renames it to the more convenient `stdtx` crate, and updates links and path references to other crates in this repo.
|
Ended up moving this over here and renaming it to |
tarcieri
pushed a commit
that referenced
this pull request
Jan 27, 2020
This reverts commit 86fc356, reversing changes made to 520727f. Migrating this crate here instead: https://github.com/iqlusioninc/crates/tree/develop/stdtx
tarcieri
added a commit
that referenced
this pull request
Jan 28, 2020
Revert "Merge pull request #401 from tendermint/cosmos-stdtx"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new crate in the KMS workspace called
cosmos-stdtx. The goal is to support generalized transaction signing across any Tendermint blockchain which uses the Cosmos SDK's StdTx format without requiring code changes in the KMS, in service of implementing #386: Cosmos transaction signing support (backed by KMS-managed keys).To accomplish this, the crate defines a TOML-based schema definition language which describes the fields of the
Msgtype used in a particularStdTx, along with the Amino name(space) for a givenStdTx. (In a future update which potentially replaces Amino with Protos, this could be replaced with a Protobuf schema definition).