This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
Fix voting power calculation error #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
There is only one validator in a testnet, the voting power of this validator is expected to be 100% but got 8.21%.
Cause
The original voting power calculation uses
supply(total supply) gotten from thegetStakingSupplyfunction as the denominator andtokenof each validator as the numerator. But should usedelegator_sharesof active validator as the denominator and its sum as the numerator.Revision
delegator_sharesof each active validator divides its sum to calculate the voting power.getStakingSupply.