Nexus Endpoint resource #221
Conversation
| worker_target_spec = { | ||
| namespace_id = temporalcloud_namespace.target_namespace.id | ||
| task_queue = "terraform-task-queue" | ||
| } | ||
| allowed_caller_namespaces = [ | ||
| temporalcloud_namespace.caller_namespace.id, | ||
| temporalcloud_namespace.caller_namespace_2.id, | ||
| ] |
There was a problem hiding this comment.
This is fine but I'm wondering if it'd be better to make the API a little more future-proof. Here's an example:
target = {
type = "worker"
namespace_id = temporalcloud_namespace.target_namespace.id
task_queue = "terraform-task-queue"
}
allowed_callers = [
{
type = "namespace"
namespace_id = "..."
}
]
But what you have is probably better for type safety.
Let's keep it as is.
| Optional: true, | ||
| Sensitive: true, | ||
| }, | ||
| "worker_target_spec": schema.SingleNestedAttribute{ |
There was a problem hiding this comment.
Should we just call this worker_target?
| } | ||
|
|
||
| func getPolicySpecsFromModel(_ context.Context, model *nexusEndpointResourceModel) ([]*nexusv1.EndpointPolicySpec, diag.Diagnostics) { | ||
| policySpecs := make([]*nexusv1.EndpointPolicySpec, 0, len(model.AllowedCallerNamespaces.Elements())) |
There was a problem hiding this comment.
Is this a sorted set? Can we ensure that nothing happens if the set elements are arbitrarily ordered?
There was a problem hiding this comment.
Terraform sets are unordered
| Name types.String `tfsdk:"name"` | ||
| Description types.String `tfsdk:"description"` | ||
| WorkerTargetSpec types.Object `tfsdk:"worker_target_spec"` | ||
| AllowedCallerNamespaces types.Set `tfsdk:"allowed_caller_namespaces"` |
There was a problem hiding this comment.
Can we make these real Go types? The TF type system will know how to do the conversion to/from go types for us. (same goes for the structs below)
| "description": schema.StringAttribute{ | ||
| Description: "The description for the Nexus endpoint.", | ||
| Optional: true, | ||
| Sensitive: true, |
There was a problem hiding this comment.
Is description meant to be marked as sensitive here?
| Required: true, | ||
| }, | ||
| "allowed_caller_namespaces": schema.SetAttribute{ | ||
| Description: "Namespace(s) that are allowed to call this Endpoint.", |
There was a problem hiding this comment.
| Description: "Namespace(s) that are allowed to call this Endpoint.", | |
| Description: "Namespace Id(s) that are allowed to call this Endpoint.", |
| Timeouts timeouts.Value `tfsdk:"timeouts"` | ||
| } | ||
|
|
||
| nexusEndpointWorkerTargetModel struct { |
There was a problem hiding this comment.
This object and the Policy object are oneofs in the API. Do we want to follow suit here and wrap these in an object? That way if a new oneof option is added we can add it as another field in the wrapping struct?
Target: {
WorkerTarget: {...}
}
Policy: {
AllowedCallerNamesoaces: [...]
}
Closes #219