Updated docs for User and Service Account #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,7 +86,7 @@ func (r *serviceAccountResource) Metadata(_ context.Context, req resource.Metada | |||
|
|
|||
| func (r *serviceAccountResource) Schema(ctx context.Context, _ resource.SchemaRequest, resp *resource.SchemaResponse) { | |||
| resp.Schema = schema.Schema{ | |||
| Description: "Provisions a Temporal Cloud Service Account.", | |||
| Description: "Provisions a Temporal Cloud Service Account. To avoid overwriting service account permissions, manage a specific service account in one and only one .tf file. ", | |||
There was a problem hiding this comment.
I'm not sure this is necessary to say here, it seems as though this is an invalid way to use Terraform altogether
There was a problem hiding this comment.
TY for the input. The reason this was provided is that users were attempting to do this, which led to the underlying issue - #119
IIRC, we agreed to update our docs and the TF docs to make this recommendation explicitly
|
Closing - guidance is provided in the Temporal docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slight update to the User and Service Account Resource docs to encourage users to follow TF best practices to avoid overwriting user and service account configurations