Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the grpc address and added the mtls grpc address to the namespa… #141

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

jlacefie
Copy link
Collaborator

What was changed

Updated the description for grpc_address and added a new mtls_grpc_address field as a part of the Namespace schema

Why?

When we bumped the Cloud Ops API version to latest, we missed this update.

Checklist

  1. Closes [Bug] namespace resource endpoints.grpc_address is null #140

  2. How was this tested:
    ran full test suite locally
    also reproduced and ran a test with a local build, output below

resource "temporalcloud_namespace" "namespace" {
...
    endpoints          = {
        mtls_grpc_address = "terraform144.ksfop.tmprl.cloud:7233"
        web_address       = "https://terraform144.ksfop.web.tmprl.cloud"
    }
 ...
}

  1. Any docs updates needed?
    generate will creat doc updates

@jlacefie jlacefie requested a review from a team as a code owner October 15, 2024 14:35
@jlacefie jlacefie merged commit 92cbaec into main Oct 15, 2024
5 checks passed
@jlacefie jlacefie deleted the jlacefie/grpcproto branch October 15, 2024 16:21
@jlacefie jlacefie changed the title updated the grp address and added the mtls grp address to the namespa… updated the grpc address and added the mtls grpc address to the namespa… Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] namespace resource endpoints.grpc_address is null
2 participants