merge ringpop services #5080
Merged
merge ringpop services #5080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeebswihart
changed the title
dnr
reviewed
Nov 7, 2023
common/membership/ringpop/monitor.go
Outdated
|
|
||
| rpo.initialized.Set(struct{}{}, nil) | ||
| } | ||
|
|
||
| // bootstrap ring pop service by discovering the bootstrap hosts and joining the ring pop cluster | ||
| func (rpo *monitor) bootstrapRingPop( | ||
| bootstrapHostPostRetriever func() ([]string, error), |
There was a problem hiding this comment.
this can be simplified more.. just call rpo.fetchCurrentBootstrapHostports directly and use healthyHostLastHeartbeatCutoff/2 for the backoff interval
Yeah probably, damnit. I have too much going on with this repo |
I was lazy when I merged these
Whoops
tdeebswihart
force-pushed
the
tdeebswihart/merge-ringpop-services
branch
from
d874c60 to
6a40b71
Compare
dnr
approved these changes
Nov 8, 2023
dnr
reviewed
Nov 8, 2023
| @@ -1,6 +1,4 @@ | |||
| version: v1beta1 | |||
| deps: | |||
| - buf.build/googleapis/googleapis | |||
There was a problem hiding this comment.
🙁 I think I needed to add this to get proto generation to work correctly on a branch
There was a problem hiding this comment.
That's weird: it broke suddenly in CI for me :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I merged the ringpop
servicewith the membership monitor.Why?
It's not a useful abstraction
How did you test it?
Potential risks
Is hotfix candidate?
No.