Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing rangeDelete for QueueV2 #5044

Closed
wants to merge 3 commits into from
Closed

Fixing rangeDelete for QueueV2 #5044

wants to merge 3 commits into from

Conversation

prathyushpv
Copy link
Contributor

What changed?
Fixing the issue with queue metadata update in RangeDelete operation

Why?
Metadata version was not set properly when updating queue v2 metadata for RangeDelete operation.

How did you test it?
Unit test

Potential risks

Is hotfix candidate?

@prathyushpv prathyushpv marked this pull request as ready for review October 27, 2023 05:25
@prathyushpv prathyushpv requested a review from a team as a code owner October 27, 2023 05:25
MichaelSnowden
MichaelSnowden suggested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@MichaelSnowden MichaelSnowden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, but I think we're going to make this even simpler by just using transactions and FOR UPDATE, so we can get rid of the version column completely.

@prathyushpv prathyushpv closed this Nov 3, 2023
@yiminc yiminc deleted the ppv/rangeDelete branch December 9, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSnowden MichaelSnowden MichaelSnowden requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prathyushpv @MichaelSnowden