Skip to content

Commit

Permalink
Add target cluster to error messaging when verify replication tasks f…
Browse files Browse the repository at this point in the history
…ails (#6936)

## What changed?
Added target cluster to explicitly clarify error message for future
debugging.

## Why?
<!-- Tell your future self why have you made these changes -->

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
  • Loading branch information
laniehei authored Jan 22, 2025
1 parent 72df948 commit 26dbd25
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions service/worker/migration/activities.go
Original file line number Diff line number Diff line change
Expand Up @@ -778,10 +778,11 @@ func (a *activities) VerifyReplicationTasks(ctx context.Context, request *verify
if diff > defaultNoProgressNotRetryableTimeout {
// Potentially encountered a missing execution, return non-retryable error
return response, temporal.NewNonRetryableApplicationError(
fmt.Sprintf("verifyReplicationTasks was not able to make progress for more than %v minutes (not retryable). Not found WorkflowExecution: %v, Checkpoint: %v",
fmt.Sprintf("verifyReplicationTasks was not able to make progress for more than %v minutes (not retryable): could not find WorkflowExecution: '%v' in TargetCluster: '%s': Checkpoint: '%v', ",
diff.Minutes(),
details.LastNotVerifiedWorkflowExecution, details.CheckPoint),
"", nil)
details.LastNotVerifiedWorkflowExecution, request.TargetClusterName, details.CheckPoint),
"",
nil)
}
}
}

0 comments on commit 26dbd25

Please sign in to comment.