Skip to content

Commit

Permalink
update old deployment component (#7150)
Browse files Browse the repository at this point in the history
## What changed?
<!-- Describe what has changed in this PR -->
- update old deployment component, for existing pre-release versioning-3
customers, so that it always registers itself when versioning-3 is
enabled on the namespace

## Why?
<!-- Tell your future self why have you made these changes -->
- fix any potential delays in worker registration in the near future

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
- existing suite of tests

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
- not a lot since this feature is still pre-release

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
- No
  • Loading branch information
Shivs11 authored Jan 24, 2025
1 parent cb4ed09 commit 0d87f75
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions service/worker/deployment/fx.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ import (
type (
workerComponent struct {
activityDeps activityDeps
enabledForNs dynamicconfig.BoolPropertyFnWithNamespaceFilter
}

activityDeps struct {
Expand Down Expand Up @@ -93,14 +92,13 @@ func NewResult(
return fxResult{
Component: &workerComponent{
activityDeps: params,
enabledForNs: dynamicconfig.EnableDeployments.Get(dc),
},
}
}

func (s *workerComponent) DedicatedWorkerOptions(ns *namespace.Namespace) *workercommon.PerNSDedicatedWorkerOptions {
return &workercommon.PerNSDedicatedWorkerOptions{
Enabled: s.enabledForNs(ns.Name().String()),
Enabled: true,
}
}

Expand Down

0 comments on commit 0d87f75

Please sign in to comment.