Skip to content

Commit

Permalink
Remove MatchingLoadUserData config (#7148)
Browse files Browse the repository at this point in the history
## What changed?
Remove this obsolete config.

## Why?
It's not used anymore.
  • Loading branch information
dnr authored Jan 23, 2025
1 parent e196abb commit 03683d3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
8 changes: 0 additions & 8 deletions common/dynamicconfig/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -1080,14 +1080,6 @@ See DynamicRateLimitingParams comments for more details.`,
primitives.GetHistoryMaxPageSize,
`MatchingHistoryMaxPageSize is the maximum page size of history events returned on PollWorkflowTaskQueue requests`,
)
MatchingLoadUserData = NewTaskQueueBoolSetting(
"matching.loadUserData",
true,
`MatchingLoadUserData can be used to entirely disable loading user data from persistence (and the inter node RPCs
that propoagate it). When turned off, features that rely on user data (e.g. worker versioning) will essentially
be disabled. When disabled, matching will drop tasks for versioned workflows and activities to avoid breaking
versioning semantics. Operator intervention will be required to reschedule the dropped tasks.`,
)
MatchingUpdateAckInterval = NewTaskQueueDurationSettingWithConstrainedDefault(
"matching.updateAckInterval",
[]TypedConstrainedValue[time.Duration]{
Expand Down
3 changes: 0 additions & 3 deletions service/matching/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ type (
VisibilityDisableOrderByClause dynamicconfig.BoolPropertyFnWithNamespaceFilter
VisibilityEnableManualPagination dynamicconfig.BoolPropertyFnWithNamespaceFilter

LoadUserData dynamicconfig.BoolPropertyFnWithTaskQueueFilter

ListNexusEndpointsLongPollTimeout dynamicconfig.DurationPropertyFn
NexusEndpointsRefreshInterval dynamicconfig.DurationPropertyFn

Expand Down Expand Up @@ -214,7 +212,6 @@ func NewConfig(
PersistenceDynamicRateLimitingParams: dynamicconfig.MatchingPersistenceDynamicRateLimitingParams.Get(dc),
PersistenceQPSBurstRatio: dynamicconfig.PersistenceQPSBurstRatio.Get(dc),
SyncMatchWaitDuration: dynamicconfig.MatchingSyncMatchWaitDuration.Get(dc),
LoadUserData: dynamicconfig.MatchingLoadUserData.Get(dc),
HistoryMaxPageSize: dynamicconfig.MatchingHistoryMaxPageSize.Get(dc),
EnableDeployments: dynamicconfig.EnableDeployments.Get(dc),
MaxTaskQueuesInDeployment: dynamicconfig.MatchingMaxTaskQueuesInDeployment.Get(dc),
Expand Down

0 comments on commit 03683d3

Please sign in to comment.