Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow replayer support #204

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Workflow replayer support #204

merged 1 commit into from
Jan 24, 2025

Conversation

cretz
Copy link
Member

@cretz cretz commented Jan 23, 2025

What was changed

Checklist

  1. Closes [Feature Request] Workflow replayer #187

@cretz cretz requested a review from a team January 23, 2025 22:35
Sushisource
Sushisource reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per what James mentioned in Slack, looks like the lang_fail eviction reason is coming across as expected in TS, so maybe something else is going on here.

README.md
@@ -62,6 +62,7 @@ until the SDK is marked stable.
- [Activity Worker Shutdown](#activity-worker-shutdown)
- [Activity Concurrency and Executors](#activity-concurrency-and-executors)
- [Activity Testing](#activity-testing)
- [Ractors](#ractors)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to auto-generate this TOC entry when I made this section last

temporalio/lib/temporalio/worker/workflow_replayer.rb
Comment on lines +262 to +263
# TODO(cretz): Unset this
@running = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo can be removed

@cretz
Copy link
Member Author

cretz commented Jan 24, 2025 •
edited
Loading

Per what James mentioned in Slack, looks like the lang_fail eviction reason is coming across as expected in TS, so maybe something else is going on here.

Is that on replaying a history after task fail (but of course while still failing)? I have a test here at test_task_failure that runs a workflow until task failure is in history, then runs it through replayer (which does fail activation again) and it doesn't come with lang_fail eviction.

Sushisource
Sushisource approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, we might need to make an adjustment or two if anything needs to change in Core pending the discussion we had

@cretz cretz merged commit c79cc61 into temporalio:main Jan 24, 2025
6 checks passed
@cretz cretz deleted the workflow-replayer-2 branch January 24, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Workflow replayer
2 participants
@cretz @Sushisource