Support for building gems and prepare release #171
Conversation
| uses: arduino/setup-protoc@v3 | ||
| with: | ||
| # TODO(cretz): Can upgrade proto when https://github.com/arduino/setup-protoc/issues/99 fixed | ||
| version: "23.x" | ||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
There was a problem hiding this comment.
To other reviewers: this has been moved to temporalio/Rakefile
| working-directory: ./temporalio | ||
| cache-version: v1-${{ matrix.rubyPlatform }} | ||
|
|
||
| - name: Cross compile gems |
There was a problem hiding this comment.
I suppose that it will output files to temporalio/internal/bridge/3.[123]/temporalio_bridge.(extension). Is that exact?
Some comments on what this action will do would be useful to future readers.
There was a problem hiding this comment.
Yes. Not really wanting to re-document what a separate action does here where we use it, but the internal/bridge.rb does have version specific loading
|
Can you please brush up a bit what you envision to be the release procedure? I don't think we need to formally include that in the repo just now, that can certainly wait until we get experience from doing a few releases. But having some idea of where you are heading to would help us in validating this PR. |
Yes, this will be documented internally alongside the release process for the other SDKs. Basically it's just downloading the gems artifacts from the build-gems GH workflow run and using |
What was changed