Skip to content

Commit

Permalink
Update version to 0.3.0
Browse files Browse the repository at this point in the history
  • Loading branch information
cretz committed Jan 17, 2025
1 parent f8002e7 commit d710fef
Show file tree
Hide file tree
Showing 7 changed files with 27 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-gems.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:
- os: ubuntu-latest
rubyPlatform: x86_64-linux
- os: macos-intel
runsOn: macos-12
runsOn: macos-13
rubyPlatform: x86_64-darwin
- os: macos-latest
rubyPlatform: arm64-darwin
Expand Down
5 changes: 5 additions & 0 deletions temporalio/.rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ AllCops:
# Keep cop rule settings in alphabetical order. For each rule setting, provide
# justification for the change from default.

# Temporarily disabled per https://github.com/rake-compiler/rake-compiler-dock/issues/145#issuecomment-2596848639
# until that is fixed
Gemspec/RequiredRubyVersion:
Enabled: false

# We want our classes in a certain order
Layout/ClassStructure:
Enabled: true
Expand Down
14 changes: 7 additions & 7 deletions temporalio/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions temporalio/Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,7 @@ Rake::Task[:build].enhance([:copy_parent_files]) do
end

task :rust_lint do
# TODO(cretz): Add "-- -Dwarnings" to clippy when SDK core passes with it
sh 'cargo', 'clippy'
sh 'cargo', 'clippy', '--', '-Dwarnings'
sh 'cargo', 'fmt', '--check'
end

Expand Down
2 changes: 1 addition & 1 deletion temporalio/lib/temporalio/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module Temporalio
VERSION = '0.2.0'
VERSION = '0.3.0'
end
1 change: 0 additions & 1 deletion temporalio/temporalio.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ Gem::Specification.new do |spec|
spec.summary = 'Temporal.io Ruby SDK'
spec.homepage = 'https://github.com/temporalio/sdk-ruby'
spec.license = 'MIT'
spec.required_ruby_version = '>= 3.1.0'

spec.metadata['homepage_uri'] = spec.homepage
spec.metadata['source_code_uri'] = 'https://github.com/temporalio/sdk-ruby'
Expand Down
15 changes: 12 additions & 3 deletions temporalio/test/runtime_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,18 @@ def test_metric_basics
assert(dump.split("\n").any? { |l| l == '# HELP my_counter_int my-counter-int-desc' })
assert_equal '46', assert_metric_line(dump, 'my_counter_int',
attr_str: 'str-val', attr_bool: true, attr_int: 123, attr_float: 4.56)
assert_equal '56', assert_metric_line(dump, 'my_counter_int',
attr_str: 'str-val', attr_bool: true,
attr_int: 234, attr_float: 4.56, another_attr: 'another-val')
# TODO(cretz): For some reason on current OTel metrics/prometheus, in rare cases this gives a line with
# 'attr_int="123;234"' though it should just be `attr_int="123"` (and is a lot of the time). Hopefully an OTel
# update will fix this.
begin
assert_equal '56', assert_metric_line(dump, 'my_counter_int',
attr_str: 'str-val', attr_bool: true,
attr_int: 234, attr_float: 4.56, another_attr: 'another-val')
rescue Minitest::Assertion
assert_equal '56', assert_metric_line(dump, 'my_counter_int',
attr_str: 'str-val', attr_bool: true,
attr_int: '123;234', attr_float: 4.56, another_attr: 'another-val')
end

assert_equal '0', assert_metric_line(dump, 'my_histogram_int_bucket', attr_str: 'str-val', le: 50)
assert_equal '1', assert_metric_line(dump, 'my_histogram_int_bucket', attr_str: 'str-val', le: 100)
Expand Down

0 comments on commit d710fef

Please sign in to comment.