Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use namespace from ClientOptions on creating of Schedule #549

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roxblnfk
Copy link
Collaborator

@roxblnfk roxblnfk commented Jan 8, 2025

What was changed

  • ScheduleOptions->naemspace has null value by default instead of "default"
  • Deprecate namespace property and withNamespace() method in ScheduleOptions
  • Use namespace from the ClientOptions as a fallback value when a Schedule is created

Checklist

  1. Closes [Bug] Namespace from ClientOptions in ScheduleClient constructor not respected in createSchedule #548
  2. How was this tested: added unit tests

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 8:35pm

@roxblnfk roxblnfk requested a review from wolfy-j January 8, 2025 20:33
Comment on lines +19 to +22
/**
* @deprecated will be removed in the next major version.
*/
public readonly ?string $namespace;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a note: ScheduleClient::getHandle still allows specifying a namespace as an argument and does not appear to be deprecated.

Currently, createSchedule creates schedules in the given namespace (while passing the namespace as an argument is marked as deprecated), whereas getHandle supports working with handles in different namespaces. Is this behavior intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to deprecate a parameter.
We will most likely remove this in the next major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Namespace from ClientOptions in ScheduleClient constructor not respected in createSchedule
2 participants