Sample - Custom Search Attributes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasonEgger
changed the title
| @@ -0,0 +1,39 @@ | |||
| # Custom Search Attributes | |||
There was a problem hiding this comment.
Meta comment, this course seems to use the deprecated old search attribute API, we now recommend users use the typed search attribute API
There was a problem hiding this comment.
Not sure what other language courses did, but I think it is worth a broader discussion on what API we should be teaching.
There was a problem hiding this comment.
I have updated this. Ready for review again
|
|
||
| Keep in mind that setting attributes is optional in some attributes' case, and this is more for setting Search Attributes that are known at the start of the Workflow or may not change through the Workflow logic. | ||
|
|
||
| ## Part C: Upserting Attributes |
There was a problem hiding this comment.
Do we want to show removing a search attribute?
There was a problem hiding this comment.
I think for this sample we won't, but I'll include it in the course content.
samples/custom-search-attributes/src/main/java/customsearchattributes/Starter.java
Outdated
Show resolved
Hide resolved
samples/custom-search-attributes/src/main/java/customsearchattributes/PizzaWorkflowImpl.java
Outdated
Show resolved
Hide resolved
Quinn-With-Two-Ns
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.