Address color level 4 deprecation warnings #5236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epetrow
force-pushed
the
color-func-deprecations
branch
from
1348a87
to
4304c07
Compare
epetrow
force-pushed
the
color-func-deprecations
branch
2 times, most recently
from
6aefd6d
to
5c40178
Compare
zhpenkov
reviewed
Nov 20, 2024
| $kendo-series-a-light: if($kendo-enable-color-system, k-color( series-a-subtle ), mix(white, $kendo-series-a, 25%)) !default; | ||
| $kendo-series-a-lighter: if($kendo-enable-color-system, k-color( series-a-subtler ), mix(white, $kendo-series-a, 50%)) !default; | ||
| $kendo-series-a-dark: if($kendo-enable-color-system, k-color( series-a-bold ), color.mix(black, $kendo-series-a, 25%)) !default; | ||
| $kendo-series-a-darker: if($kendo-enable-color-system, k-color( series-a-bolder ), color.mix(black, $kendo-series-a, 50%)) !default; |
There was a problem hiding this comment.
There are some occurrences (not in this particular file) of the custom k-color-mix() being used.
This mean that as of now we use both color.mix() and k-color-mix() in our codebase, which are practically the same.
kendo-themes/packages/core/scss/functions/_color.import.scss
Lines 87 to 90 in 7e81c25
I suggest sticking to one of them for code consistency.
My suggestion -
color.mix().
There was a problem hiding this comment.
@telerik/kendo-front-end
There was a problem hiding this comment.
I agree that using a single color function is a better approach. Also, my preference is for color.mix()
inikolova
approved these changes
Nov 22, 2024
epetrow
force-pushed
the
color-func-deprecations
branch
from
d7fbb2d
to
b53efc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to changes in Sass color functions here