Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add prop for removing tabindex #2215

Merged
merged 3 commits into from
Nov 24, 2023
Merged

fix: add prop for removing tabindex #2215

merged 3 commits into from
Nov 24, 2023

Conversation

felix-ico
Copy link
Collaborator

@felix-ico felix-ico commented Nov 21, 2023

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 9c23883
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/6560a7c7d886ca00085f0d2b
😎 Deploy Preview https://deploy-preview-2215--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@acstll acstll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to document it in Storybook!

@felix-ico
Copy link
Collaborator Author

Would be great to document it in Storybook!

I added the prop in storybook but there seems to be now way of adding a more detailed description for subcomponents though :/ (storybookjs/storybook#14710) - it is documented in the component readme...

@felix-ico felix-ico merged commit 3fdafab into main Nov 24, 2023
11 checks passed
@felix-ico felix-ico deleted the fix/focusable-tab-panel branch November 24, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants