Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not try cast when expandVar entity id and entity type #792

Merged
merged 5 commits into from
Jul 22, 2024
Merged

do not try cast when expandVar entity id and entity type #792

merged 5 commits into from
Jul 22, 2024

Conversation

AlvaroVega
Copy link
Member

Fix for: #791

@AlvaroVega AlvaroVega requested a review from fgalan July 19, 2024 08:58
fgalan
fgalan reviewed Jul 22, 2024
View reviewed changes
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
fgalan
fgalan approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 945f0a8 into master Jul 22, 2024
5 checks passed
@fgalan fgalan deleted the fix/do_not_expand_to_non_string_id_type_entity branch July 22, 2024 08:24
@fgalan fgalan mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvaroVega @fgalan