Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX software quality improvement based on ISO25010 recommendations #428

Merged

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Feb 6, 2020

This PR mimics contributed PR #419 from @fiqare-emergya-dev, squashing its >100 commits into a single one. Note that the diff checksum in the first commit (4877a73) matches the one of the original PR ( +438 −27 )

Some additional commits will include additional adjustments.

@fgalan
Copy link
Member Author

fgalan commented Feb 6, 2020

Commits added after first one:

  • 9af1e97, fixing the swagger section in development.md doc, removing redundant information (already provided in deployment.md)
  • 2365b17, merge from master, to upgrade branch. This cause travis to fail, as the changes done metrics test in PR Fiqare perseo-fe improvements #419 are not aligned with latest changes in master
  • 900ffcf, fixing the test and making travis work again

Thus, the PR should be ready to merge now. It would be great if @fiqare-emergya-dev could provide LGTM on this PR before final merging in master.

Copy link
Contributor

@fiqare-emergya-dev fiqare-emergya-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, everything is correct.

Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlvaroVega AlvaroVega merged commit 2a09897 into master Feb 6, 2020
@AlvaroVega AlvaroVega deleted the hardening/fiqare-perseo-fe-improvements-prelanding branch February 6, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants