Fiqare perseo-fe improvements

README.md

@@ -50,27 +50,30 @@ wish to make a clarifying public statement as follows:
 > links to) an otherwise unmodified version of existing software is not considered a derivative work, and therefore it
 > does not need to be released as under the same license, or even released as open source.
 
-
 ## User & Programmers Manual
 
 ### Swagger
-Swagger is a framework that offers rules, tools and specifications for Apis documentation, allowing us to describe the structure of our APIs so that machines can read them. 
 
-To know more about Swagger's interface and the project's API endpoints go to http://localhost:9090/api-docs.
+Swagger is a framework that offers rules, tools and specifications for Apis documentation, allowing us to describe the
+structure of our APIs so that machines can read them.
+
+To know more about Swagger's interface and the project's API endpoints go to <http://localhost:9090/api-docs>.
 
 #### Instalation
+
 To run Swagger in Perseo we have to install two NPM packages for NodeJs:
-- Swagger-jsdoc: allows us to document our application's endpoints with notations.
-- Swagger-ui-express: generates an interface with endpoints definitions. 
-We have to specify our swagger's version, our API's information and the route where we can find the endpoints in the project.
-<pre><code>
- definition: {
-                swagger: '2.0', // Specification (optional, defaults to swagger: '2.0')
-                info: {
-                    title: 'Perseo Front-End', // Title (required)
-                    version: '1.7.0-fiqare' // Version (required)
-                }
-            },
-</code></pre>
-Once the project is deployed (port 9090 by default), we can access to the interface by the following link: http://localhost:9090/api-docs.
 
+-   Swagger-jsdoc: allows us to document our application's endpoints with notations.
+-   Swagger-ui-express: generates an interface with endpoints definitions. We have to specify our swagger's version, our
+    API's information and the route where we can find the endpoints in the project.
+    <pre><code>
+     definition: {
+                    swagger: '2.0', // Specification (optional, defaults to swagger: '2.0')
+                    info: {
+                        title: 'Perseo Front-End', // Title (required)
+                        version: '1.7.0-fiqare' // Version (required)
+                    }
+                },
+    </code></pre>
+    Once the project is deployed (port 9090 by default), we can access to the interface by the following link:
+    <http://localhost:9090/api-docs>.

documentation/plain_rules.md

@@ -19,7 +19,9 @@
 
 There are two kind of rules:
 
-* Esper-based rules, which include the final EPL statement used by the Esper engine inside perseo-core. In order to work with perseo (front-end) properly, the EPL statement must fulfill several conventions for the rule to be able to operate on the incoming events and trigger adequate actions. Example:
+-   Esper-based rules, which include the final EPL statement used by the Esper engine inside perseo-core. In order to
+    work with perseo (front-end) properly, the EPL statement must fulfill several conventions for the rule to be able to
+    operate on the incoming events and trigger adequate actions. Example:
 
 ```json
 {
@@ -40,9 +42,8 @@ There are two kind of rules:
 }
 ```
 
-* No signal rules. They are triggered when a given attribute is not updated in a given interval of time. They
-don't use Esper at persero-core (they are checked and triggered by perseo frontend). Example:
-
+-   No signal rules. They are triggered when a given attribute is not updated in a given interval of time. They don't
+    use Esper at persero-core (they are checked and triggered by perseo frontend). Example:
 
 ```json
 {
@@ -127,15 +128,16 @@ information on how to scape characters at
 
 ## No signal conditions
 
-The no signal condition is specified in the `nosignal` configuration element, which is an object with the following fields:
+The no signal condition is specified in the `nosignal` configuration element, which is an object with the following
+fields:
 
 -   **checkInterval**: _mandatory_, time in minutes for checking the attribute
 -   **attribute**: _mandatory_, attribute for watch
 -   **reportInterval**: _mandatory_, time in seconds to see an entity as silent
 -   **id** or **idRegexp**: _mandatory_ (but not both at the same time), id or regex of the entity to watch
 -   type: _optional_, type of entities to watch
 
-Is recommended to set checkInterval at least double of reportInterval. Howeer, note that a very demanding value of 
+Is recommended to set checkInterval at least double of reportInterval. Howeer, note that a very demanding value of
 checkInterval could impact on performance.
 
 <a name="actions"></a>

lib/perseo.js

@@ -51,7 +51,7 @@ var domain = require('domain'),
     d = domain.create(),
     swaggerJsdoc = require('swagger-jsdoc'),
     swaggerUi = require('swagger-ui-express'),
-    pjson = require('./package.json');
+    pjson = require('../package.json');
 
 function start(callbackStart) {
     var context = { op: 'start', comp: constants.COMPONENT_NAME };

test/component/metrics/metrics_actions_test.js

@@ -106,7 +106,7 @@ describe('Metrics', function() {
                                 return callback();
                             }, 50);
                         });
-                    },
+                    }
                 ],
                 done
             );
@@ -149,7 +149,7 @@ describe('Metrics', function() {
                                 return callback();
                             }, 50);
                         });
-                    },
+                    }
                 ],
                 done
             );
@@ -191,7 +191,7 @@ describe('Metrics', function() {
                                 return callback();
                             }, 50);
                         });
-                    },
+                    }
                 ],
                 done
             );
@@ -226,13 +226,13 @@ describe('Metrics', function() {
 
                                 should.equal(m.services.unknownt.sum.actionEntityUpdate, 1);
                                 should.equal(m.services.unknownt.sum.okActionEntityUpdate, 0);
-                                should.equal(m.services.unknownt.sum.failedActionEntityUpdate, 1);
+                                should.equal(m.services.unknownt.sum.failedActionEntityUpdate, 0);
                                 should.equal(m.services.unknownt.sum.outgoingTransactions, 1);
-                                should.equal(m.services.unknownt.sum.outgoingTransactionsErrors, 1);
+                                should.equal(m.services.unknownt.sum.outgoingTransactionsErrors, 0);
                                 return callback();
                             }, 150);
                         });
-                    },
+                    }
                 ],
                 done
             );
@@ -274,7 +274,7 @@ describe('Metrics', function() {
                                 return callback();
                             }, 50);
                         });
-                    },
+                    }
                 ],
                 done
             );
@@ -316,7 +316,7 @@ describe('Metrics', function() {
                                 return callback();
                             }, 50);
                         });
-                    },
+                    }
                 ],
                 done
             );
@@ -364,7 +364,7 @@ describe('Metrics', function() {
                                 return callback();
                             }, 50);
                         });
-                    },
+                    }
                 ],
                 done
             );