Merge pull request #797 from telefonicaid/fix/smtp_conf_auth_tained_a…

…fter_error

ensure smtpConfig auth is not tainted for log purposes when error

CHANGES_NEXT_RELEASE

@@ -0,0 +1 @@
+- Fix: smtpConfig after error in emailAction rule (#798)

lib/models/emailAction.js

@@ -80,10 +80,10 @@ function SendMail(action, event, callback) {
             smtpConfig = config.smtp;
             msgFromConfig = 'from global';
         }
-        var smtpAuth = smtpConfig.auth;
-        smtpConfig.auth = { user: 'UUU', pass: 'XXX' };
+        var smtpAuth = Object.assign({}, smtpConfig.auth); // force clone
+        smtpConfig.auth = { user: 'UUU', pass: 'XXX' }; // fake auth for log purposes
         logger.debug('Using smtp transporter %j config: %j', msgFromConfig, smtpConfig);
-        smtpConfig.auth = smtpAuth;
+        smtpConfig.auth = smtpAuth; // restore auth
         transporter = nodemailer.createTransport(smtpTransport(smtpConfig));
         metrics.IncMetrics(event.service, event.subservice, metrics.actionEmail);
 
@@ -105,6 +105,7 @@ function SendMail(action, event, callback) {
                 };
                 opt2log.smtp.auth = { user: 'UUU', pass: 'XXX' };
                 myutils.logErrorIf(err, util.format('emailAction.SendMail %j', opt2log));
+                smtpConfig.auth = smtpAuth; // ensure smtpConfig.auth is not tainted
                 alarm.raise(alarm.EMAIL);
             } else {
                 metrics.IncMetrics(event.service, event.subservice, metrics.okActionEmail);