Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add response header about procesing time #685

Merged
merged 9 commits into from
Sep 27, 2024

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega changed the title add_response_header_procesing_time add response header procesing time Sep 23, 2024
Changelog Outdated Show resolved Hide resolved
AlvaroVega and others added 2 commits September 23, 2024 15:36
AMQP_DEFAULT_RETRY_TIME: 5
AMQP_DEFAULT_RETRY_TIME: 5,

X_PROCESSING_TIME: 'X-Processing-Time'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is based in some existing (pseudo)standard? Or it has been fully invented?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just a new invented header. But we can use other...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should do a little searching to check is there is something similar we can reuse or inspire on...

Copy link
Member Author

@AlvaroVega AlvaroVega Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe X-Process-Time matches better?

@AlvaroVega AlvaroVega changed the title add response header procesing time add response header about procesing time Sep 24, 2024
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan
Copy link
Member

fgalan commented Sep 27, 2024

Twin PR telefonicaid/iotagent-json#845

@fgalan fgalan merged commit e61e33a into master Sep 27, 2024
7 checks passed
@fgalan fgalan deleted the task/add_response_header_procesing_time branch September 27, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants