Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-run eslint #415

Merged
merged 9 commits into from
Jul 3, 2020
Merged

Re-run eslint #415

merged 9 commits into from
Jul 3, 2020

Conversation

jason-fox
Copy link
Contributor

@jason-fox jason-fox commented Jan 21, 2020

Update codebase to use ES6

  • Remove JSHint and jshint overrides
  • Add esLint using standard tamia presets
  • Replace var with let/const
  • Fix or disable eslint errors

Repeats #408 closed in error

@fgalan fgalan mentioned this pull request Jan 22, 2020
package.json Outdated
@@ -46,6 +46,9 @@
},
"devDependencies": {
"coveralls": "~3.0.2",
"eslint": "~5.16.0",
"eslint-config-tamia": "~6.2.1",
"eslint-plugin-prettier": "~3.1.2",
"husky": "~1.1.0",
"istanbul": "~0.4.5",
"jshint": "~2.9.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Fix c7f6743

Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit bb3d5ee into telefonicaid:master Jul 3, 2020
This was referenced Jul 3, 2020
@jason-fox jason-fox deleted the feature/eslint branch July 14, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants