Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secmotic fiQare PR #407

Conversation

fiqare-secmotic
Copy link

@fiqare-secmotic fiqare-secmotic commented Nov 21, 2019

This pull request contains improvements made by the Secmotic team for iotagent-ul. These improvements are part of the fiQare project, which is based on ISO 25010 to improve software quality. More info: https://fiqare.eu/

  1. Swagger is provided for HTTP protocol in:
    <server_host>:7896/api-docs
  • Note: npm install is needed
  1. There are four rules:

    Rule 1: Variables should not be shadowed
    Rule 2: Unused function parameters should be removed
    Rule 3: Function parameters, caught exceptions and foreach variables should not be reassigned
    Rule 4: if.. else if constructs should end with else clauses

All test in Travis has been passed successfully and the coverage in Coveralls remains the same.

@fiqare-secmotic fiqare-secmotic changed the title Secmotic fiQare PR2 Secmotic fiQare PR Nov 21, 2019
@fgalan
Copy link
Member

fgalan commented Nov 26, 2019

Thanks you very much for your contribution!

Please have a look to the comments provided in telefonicaid/perseo-fe#416 (when applicable).

@fgalan
Copy link
Member

fgalan commented Dec 17, 2019

Continues in PR #411 y PR #412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants