-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to turn shared subscription off or change the group identifier #754
base: master
Are you sure you want to change the base?
Conversation
if ( | ||
amqpConfig.options && amqpConfig.options.durable | ||
) { | ||
if (amqpConfig.options && amqpConfig.options.durable) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code of this file was tainted, but no really changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is due linting and/or prettier. I just ran the scripts defined in the package.json
@@ -74,15 +74,15 @@ function serializedPayloadCommand(payload, command) { | |||
*/ | |||
function generateCommandExecution(apiKey, device, attribute) { | |||
let payload = {}; | |||
let command = device && device.commands.find((att) => att.name === attribute.name); | |||
const command = device && device.commands.find((att) => att.name === attribute.name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
command could be modified in line 99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also linitng and prettier
Maybe new configuration option about disable shared subscription should be also added an explained into: https://github.com/telefonicaid/iotagent-json/blob/master/docs/installationguide.md#mqtt-configuration |
As described in the twin PR I only really changed the following files:
|
topics.push(constants.MQTT_SHARE_SUBSCRIPTION_GROUP + '/+/+/' + constants.MEASURES_SUFIX + '/+'); | ||
topics.push( | ||
constants.MQTT_SHARE_SUBSCRIPTION_GROUP + | ||
if (config.getConfig().mqtt.sharedSubscriptionsDisabled === true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly no idea why the test is failing or timing out, here are my test results (16.x): 129 passing (13s)
(18.x) 129 passing (13s)
|
Twin PR, same changes.