Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/add timeout connection #2441

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Task/add timeout connection #2441

merged 5 commits into from
Nov 13, 2024

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Nov 12, 2024 •
edited
Loading

#2440

This PR adds two new options to arcgis sink with the following means:

Parameter Mandatory Default value Comments
arcgis_connectionTimeout no 0 Sets a specified timeout value, in milliseconds, to be used when opening a communications link to the arcgis. A timeout of zero is interpreted as an infinite timeout
arcgis_readTimeout no 0 Sets the read timeout to a specified timeout, in milliseconds. A timeout of zero is interpreted as an infinite timeout

An example of use In cygnus agent.conf would be (fix to 30 seconds):

cygnus-ngsi.sinks.arcgis-sink.arcgis_connectionTimeout = 30000
cygnus-ngsi.sinks.arcgis-sink.arcgis_readTimeout = 30000

@AlvaroVega AlvaroVega marked this pull request as ready for review November 13, 2024 09:22
@AlvaroVega AlvaroVega requested a review from fgalan November 13, 2024 09:57
fgalan
fgalan reviewed Nov 13, 2024
View reviewed changes
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
fgalan
fgalan approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 3f4d365 into master Nov 13, 2024
7 checks passed
@fgalan fgalan deleted the task/add_timeout_connection branch November 13, 2024 10:07
@fgalan fgalan mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvaroVega @fgalan