Add Setting to Dump Output Queue When Connecting #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add loading bar and more information to connection notification - Convert all connection functions to async so they can await the progress callback
jharajeev55
previously approved these changes
Nov 12, 2024
jharajeev55
reviewed
Nov 12, 2024
esarver
added a commit
that referenced
this pull request
Nov 12, 2024
jharajeev55
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes developers may want TSP Toolkit to show the contents of the output queue of the instrument when connecting instead of the queue being cleared. This is especially helpful when connecting to an instrument after the terminal is lost or the instrument drops the connection.
This PR also improves the notifications shown while connecting to keep the user informed of the progress of connecting to the instrument.