TSP-839 Fix issue with naming of instrument connection #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we connect to an instrument, the information (io_type, instr_address, model, serial_number, friendly_name etc.) is saved to settings.json. Any item in Instruments pane (discovered or saved) is initially created with label <model#serial_number>. For saved instruments we need to update this to any connection_name if specified by user and this information is fetched from settings.json. Since the settings.json was not updated correctly due to not awaiting, the Instruments pane showed wrong label as compared to terminal name. This is fixed by awaiting when settings.json file is updated.