Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vulnerable package and SBOM step #58

Merged
merged 1 commit into from
Oct 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ jobs:

sbom:
name: Generate CycloneDX
# Temporarily skip this step because the cyclonedx package is has a vulnerability
# https://github.com/CycloneDX/cyclonedx-node-npm/issues/1224
if: false
runs-on: ubuntu-latest
container:
image: ghcr.io/tektronix/tsp-toolkit-build:latest
Expand Down Expand Up @@ -192,7 +195,7 @@ jobs:
needs:
- compile
- test
- sbom
#- sbom
- lint
- style
if: ${{ (endsWith(github.base_ref, 'main') && (contains(github.head_ref, 'release/')) && github.event.pull_request.merged ) }}
Expand Down Expand Up @@ -229,7 +232,7 @@ jobs:
needs:
- compile
- test
- sbom
#- sbom
- lint
- style
if: ${{ (endsWith(github.base_ref, 'main') && (contains(github.head_ref, 'release/')) || github.event.pull_request.merged ) }}
Expand Down Expand Up @@ -282,11 +285,11 @@ jobs:
pattern: package-*
merge-multiple: true
path: extension
- name: Get SBOM
uses: actions/download-artifact@v4
with:
name: software-bom
path: sbom
#- name: Get SBOM
# uses: actions/download-artifact@v4
# with:
# name: software-bom
# path: sbom
- name: Get Changelog for this Tag
id: changelog
uses: coditory/changelog-parser@v1
Expand All @@ -296,7 +299,8 @@ jobs:
uses: ncipollo/release-action@v1
with:
name: ${{steps.lasttag.outputs.version}}
artifacts: "extension/*.vsix,sbom/**/*"
#artifacts: "extension/*.vsix,sbom/**/*"
artifacts: "extension/*.vsix"
body: |
## Features Requests / Bugs

Expand Down
Loading
Loading