Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Info Conversion with Prompts #31

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Fix Info Conversion with Prompts #31

merged 3 commits into from
Nov 8, 2024

Conversation

esarver
Copy link
Member

@esarver esarver commented Nov 8, 2024

There was an issue with the InstrumentInfo::try_from(&[u8]) function in which it didn't handle input that could have lines with TSP> prompts.

This PR corrects that issue by skipping any lines that do not have exactly 4 parts after splitting on ,.

@esarver esarver self-assigned this Nov 8, 2024
@esarver esarver requested a review from a team as a code owner November 8, 2024 15:24
@esarver esarver merged commit edda390 into main Nov 8, 2024
9 checks passed
@esarver esarver deleted the bug/fix-info-conversion branch November 8, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant