Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/fix 3700 platform flash issues #10

Merged
merged 6 commits into from
Jun 24, 2024

Conversation

c3charvat
Copy link
Contributor

changes include:

  • Removing the debug config at the direction of @esarver
  • Adding the 37xx platform
    A. Changing the flash portion of the code to match what has previously been done
    B. Adding the newly created instrument to mod.rs

@c3charvat c3charvat requested a review from a team as a code owner June 24, 2024 17:48
@CLAassistant
Copy link

CLAassistant commented Jun 24, 2024

CLA assistant check
All committers have signed the CLA.

@c3charvat c3charvat changed the title Improvement/fix 3700 platfrom flash issues Improvement/fix 3700 platform flash issues Jun 24, 2024
Copy link
Member

@esarver esarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution! Just one request to address.

src/model/ki3700.rs Show resolved Hide resolved
@esarver esarver self-requested a review June 24, 2024 18:45
@esarver esarver merged commit 6e19a86 into tektronix:main Jun 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants