Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Merge canary into master #34

Merged
merged 32 commits into from
Oct 4, 2020
Merged

Merge canary into master #34

merged 32 commits into from
Oct 4, 2020

Conversation

ethall
Copy link
Collaborator

@ethall ethall commented Oct 4, 2020

Pull Request Checklist

  • Code passes linting.
  • Code passes unit tests.
  • Code coverage is the same or better.

zkoppert and others added 30 commits August 27, 2019 17:09
This will automatically add the listed members as code reviewers to all pull requests.
The link is broken when executing it from a pull request unless the full URL is given.
* Dropped Python3.5 support

* Added pipenv

* Added black formatter

* Added isort

* Reformatted code with black and isort

* Replaced pylint with flake8

* Added mypy

* Updated CONTRIBUTING installation instructions
* Updated sortedcontainers

* Updated pandas

* Added metadata archive tests

* Simplified metafile merging logic
* Added check submodule

* Updated archive's functional and command-line arguments

* Updated build's functional and command-line arguments

* Having too few arguments now returns 1

* Updated trove classifiers and module description

* Removed Context for more expressive arguments

* Removed get_parser from root-level module exports

* Reorganized to resolve import collisions

* Fixed archive not checking for schema file existence

* Updated checkcolumns error message (#3)

* Error on nonexistent archive source files (#2)

* Formatted with black, isort
It was too confusing and caused 3rd party Git GUI tools to struggle.
* Added relative path support for target param of `check` (#22)

* Added relative path support for hashfile param of `check` (#22)

* Updated existing unit tests

* Added new unit tests

* Updated docs
* Updated `build` to use unmodified output path in hash entries. (#25)

* Updated `build` to verify the output path is a file.

* Updated archive & build hash_filepath docs. (#23 orphan)
* Converted `str.format` to f-strings.

* Removed unnecessary use of string templates.

* Simplified string construction in Hash classes.

* Refactored lock manager tests to use `LocalPath.make_numbered_dir`.
* Updated pandas to 1.0

* Updated sortedcontainers to 2.2
* Send raw cache and hash paths to `archive`

* `archive` cache- & hash-file input integrity tests

* Update `archive` docs

* Updated pandas testing references
* Removed reindex of new dataset during build
This example wasn't updated when the unit test directory was moved.
@ethall ethall self-assigned this Oct 4, 2020
@ethall ethall closed this Oct 4, 2020
@ethall ethall reopened this Oct 4, 2020
@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          595       593    -2     
=========================================
- Hits           595       593    -2     
Impacted Files Coverage Δ
syphon/core/build.py 100.00% <ø> (ø)

@ethall
Copy link
Collaborator Author

ethall commented Oct 4, 2020

See #31 for automatic check failure background.

@ethall ethall merged commit 147c48e into master Oct 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants