Static Code Analysis changes

[nfelt14]

Proposed changes

This PR updates the code to pass more static code analysis checks.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

• Bug fix (non-breaking change which fixes an issue)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I have followed the guidelines in the CONTRIBUTING document
• I have signed the CLA
• I have checked to ensure there aren't other open Pull Requests for the same update/change
• I have created (or updated) an Issue to track the status of this update/change and updated the link in this PR description (see above in the Proposed changes section) using the wording Addresses #<issue_number>
• I have performed a self-review of my code
• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• Basic linting passes locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have added necessary documentation (if appropriate)
• I have updated the Changelog with a brief description of my changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.61%. Comparing base (41cb7ec) to head (79df11d).
Report is 33 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   77.61%   77.61%           
=======================================
  Files           3        3           
  Lines         487      487           
  Branches      106      106           
=======================================
  Hits          378      378           
  Misses         89       89           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Breaking API Changes

src/tekhsi/tek_hsi_connect.py:0: TekHSIConnect.prevheaders:
Public object was removed

src/tekhsi/tek_hsi_connect.py:237: TekHSIConnect.any_acq(prevheader):
Parameter was removed

src/tekhsi/tek_hsi_connect.py:237: TekHSIConnect.any_acq(currentheader):
Parameter was removed

src/tekhsi/tek_hsi_connect.py:237: TekHSIConnect.any_acq(previous_header):
Parameter was added as required

src/tekhsi/tek_hsi_connect.py:237: TekHSIConnect.any_acq(current_header):
Parameter was added as required

src/tekhsi/tek_hsi_connect.py:253: TekHSIConnect.any_horizontal_change(prevheader):
Parameter was removed

src/tekhsi/tek_hsi_connect.py:253: TekHSIConnect.any_horizontal_change(currentheader):
Parameter was removed

src/tekhsi/tek_hsi_connect.py:253: TekHSIConnect.any_horizontal_change(previous_header):
Parameter was added as required

src/tekhsi/tek_hsi_connect.py:253: TekHSIConnect.any_horizontal_change(current_header):
Parameter was added as required

src/tekhsi/tek_hsi_connect.py:281: TekHSIConnect.any_vertical_change(prevheader):
Parameter was removed

src/tekhsi/tek_hsi_connect.py:281: TekHSIConnect.any_vertical_change(currentheader):
Parameter was removed

src/tekhsi/tek_hsi_connect.py:281: TekHSIConnect.any_vertical_change(previous_header):
Parameter was added as required

src/tekhsi/tek_hsi_connect.py:281: TekHSIConnect.any_vertical_change(current_header):
Parameter was added as required

Link to workflow run

[github-actions]

Test Results (ubuntu)

path	passed	subtotal
tests/test_client.py	62	62
tests/test_helpers.py	1	1
TOTAL	63	63

Link to workflow run

[github-actions]

Test Results (windows)

path	passed	subtotal
tests\test_client.py	62	62
tests\test_helpers.py	1	1
TOTAL	63	63

Link to workflow run

[github-actions]

Test Results (macos)

path	passed	subtotal
tests/test_client.py	62	62
tests/test_helpers.py	1	1
TOTAL	63	63

Link to workflow run

[tekperson]

I didn't see anything concerning here. But when whl files (or pip install) is available I'd very much like to rerun all of the examples. I do wonder why digital channels was removed from the test server (digital support is shipping). But that isn't a showstopper.