Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to GitHubAction for GolangCI Lint #915

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Migrate to GitHubAction for GolangCI Lint #915

merged 2 commits into from
Jan 17, 2025

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Jan 15, 2025

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 15, 2025
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 15, 2025
@khrm
Copy link
Contributor Author

khrm commented Jan 15, 2025

/release-note-none
/kind misc

@tekton-robot
Copy link

@khrm: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none
/kind misc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jan 15, 2025
khrm
khrm commented Jan 15, 2025
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @enarha

@khrm
Copy link
Contributor Author

khrm commented Jan 15, 2025

/assign @vdemeester

vdemeester
vdemeester approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 15, 2025
@afrittoli
Copy link
Member

/hold the action did not run yet because the configuration was missing to allow it. We should check if this passes the action check before merging 🙏

@afrittoli afrittoli closed this Jan 15, 2025
@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
@afrittoli afrittoli reopened this Jan 15, 2025
@afrittoli afrittoli closed this Jan 15, 2025
@afrittoli afrittoli reopened this Jan 15, 2025
@afrittoli
Copy link
Member

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
@afrittoli
Copy link
Member

@khrm could you fix the issues found by the linter in this PR?

@khrm
Copy link
Contributor Author

khrm commented Jan 16, 2025

@afrittoli Sure. Fixing those.

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%

@khrm khrm closed this Jan 16, 2025
@khrm khrm reopened this Jan 16, 2025
@khrm khrm force-pushed the golangci-lint-action branch from 1e0d4b1 to d8fda02 Compare January 16, 2025 06:20
@enarha
Copy link
Contributor

enarha commented Jan 16, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
@khrm khrm closed this Jan 16, 2025
@khrm khrm reopened this Jan 16, 2025
@khrm khrm closed this Jan 16, 2025
@khrm khrm reopened this Jan 16, 2025
@khrm
Copy link
Contributor Author

khrm commented Jan 16, 2025

It seems there is something wrong with Tide. It is saying that PR can't be rebased. @afrittoli

@khrm
Copy link
Contributor Author

khrm commented Jan 16, 2025

@vdemeester Any idea why it's saying that PR can't be rebased?

@afrittoli
Copy link
Member

@khrm have you tried rebasing it locally? Perhaps there is a merge conflict

@khrm
Copy link
Contributor Author

khrm commented Jan 16, 2025

/retest-required

@khrm
Copy link
Contributor Author

khrm commented Jan 16, 2025

/test pull-tekton-results-go-coverage

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%

@khrm khrm force-pushed the golangci-lint-action branch from d8fda02 to 3548df4 Compare January 17, 2025 06:14
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
@khrm
Migrate to GitHubAction for GolangCI Lint
3f2a342 
This fixes the issues related to GolangCI Lint.
@khrm khrm force-pushed the golangci-lint-action branch from 3548df4 to 3f2a342 Compare January 17, 2025 06:15
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%

@khrm
Copy link
Contributor Author

khrm commented Jan 17, 2025

I already did git rebase main. Now, I recreated this PR from scratch. Let's see what happens.

@avinal
Copy link
Member

avinal commented Jan 17, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
@khrm khrm merged commit fce8ade into tektoncd:main Jan 17, 2025
7 checks passed
@khrm
Copy link
Contributor Author

khrm commented Jan 17, 2025

/cherry-pick release-v0.13.x

@khrm khrm deleted the golangci-lint-action branch January 17, 2025 06:48
@tekton-robot
Copy link

@khrm: new pull request created: #921

In response to this:

/cherry-pick release-v0.13.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Jan 17, 2025
Merged
@jkhelil
Copy link
Member

jkhelil commented Jan 17, 2025

/cherry-pick release-v0.12.x

@tekton-robot
Copy link

@jkhelil: new pull request created: #922

In response to this:

/cherry-pick release-v0.12.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@alan-ghelardi alan-ghelardi Awaiting requested review from alan-ghelardi

@enarha enarha Awaiting requested review from enarha

Assignees

@vdemeester vdemeester

@enarha enarha

@avinal avinal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@khrm @tekton-robot @afrittoli @enarha @avinal @jkhelil @vdemeester