Fix Panic in the API server

API server gets panic under certain negative scenarios. We fixed that by creating a new variable for error.
tektoncd · Nov 4, 2024 · f056241 · f056241
1 parent 1352cec
commit f056241
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/api/server/v1alpha2/plugin_logs.go b/pkg/api/server/v1alpha2/plugin_logs.go
@@ -169,8 +169,8 @@ func (s *LogPluginServer) getLokiLogs(writer *logs.BufferedLog, parent string, r
 	req.Header.Set("Authorization", "Bearer "+token.AccessToken)
 	resp, err := s.client.Do(req)
 	if err != nil {
-		dump, err := httputil.DumpRequest(req, true)
-		if err == nil {
+		dump, derr := httputil.DumpRequest(req, true)
+		if derr == nil {
 			s.logger.Debugf("Request Dump***:\n %q\n", dump)
 		}
 		s.logger.Errorf("request to loki failed, err: %s, req: %v", err.Error(), req)