Use io.ReadFull to read the bundle content #8389
Conversation
The io.Reader documentation says: > Read reads up to len(p) bytes into p. It returns the number of bytes > read (0 <= n <= len(p)) and any error encountered. ... If some data is > available but not len(p) bytes, Read conventionally returns what is > available instead of waiting for more. Read is not guaranteed to fill the data argument. Use io.ReadFull to fill the buffer. In some cases (a relatively big bundle), the bundle content was not completely read and it would fail to parse. Using `io.ReadFull` fixes the issue. Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot
added
release-note
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/cherry-pick release-v0.65.x |
|
/cherry-pick release-v0.62.x |
|
/cherry-pick release-v0.59.x |
|
/cherry-pick release-v0.56.x |
|
@vdemeester: new pull request created: #8390 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vdemeester: new pull request created: #8391 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vdemeester: new pull request created: #8392 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vdemeester: new pull request created: #8393 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -194,7 +194,7 @@ func readTarLayer(layer v1.Layer) ([]byte, error) { | |||
| } | |||
|
|
|||
| contents := make([]byte, header.Size) | |||
There was a problem hiding this comment.
header.Size is smaller than the actual size?
There was a problem hiding this comment.
Nope it has the right size.
There was a problem hiding this comment.
Then why does it not read all the data into the buffer of the right size?
(Likely a noob question 😅)
There was a problem hiding this comment.
Read reads up to len(p) bytes into p. It returns the number of bytes
read (0 <= n <= len(p)) and any error encountered. ... If some data is
available but not len(p) bytes, Read conventionally returns what is
available instead of waiting for more.
io.Reader doesn't give you that guarantee. Why ? I am not sure 🙃
Changes
The io.Reader documentation says:
Read is not guaranteed to fill the data argument. Use io.ReadFull to
fill the buffer.
In some cases (a relatively big bundle), the bundle content was not
completely read and it would fail to parse. Using
io.ReadFullfixesthe issue.
Signed-off-by: Vincent Demeester [email protected]
/kind bug
Closes #8388
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes