Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.56.x] Run finally pipeline even if task is failed at the validation #8370

Conversation

tekton-robot
Copy link
Collaborator

This is an automated cherry-pick of #8314

/assign vdemeester

NONE

Presently if one of the task in pipeline is consuming result from the previous task
but the previous failed to produce the result then pipeline fails without running
the finally tasks. These changes handles tasks which got failed in the validation
step.

Signed-off-by: divyansh42 <[email protected]>
Signed-off-by: divyansh42 <[email protected]>
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 5, 2024
@vdemeester
Copy link
Member

/kind bug
/approve
/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. kind/bug Categorizes issue or PR as related to a bug. labels Nov 5, 2024
@tekton-robot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@tekton-robot
Copy link
Collaborator Author

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 91.7% 91.8% 0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.2% 95.9% -0.2
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.2% 99.1% -0.1
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 98.4% 98.3% -0.1

@tekton-robot
Copy link
Collaborator Author

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 91.7% 91.8% 0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.2% 95.9% -0.2
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.2% 99.1% -0.1
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 98.4% 99.2% 0.8

@tekton-robot tekton-robot merged commit 95e7a4e into tektoncd:release-v0.56.x Nov 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants