Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve step.Script variables references validation message #8312

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat: improve step.Script variables references validation message #8312

merged 1 commit into from
Jan 9, 2025
+67 −8

Conversation

chengjoey
Copy link
Member

@chengjoey chengjoey commented Oct 2, 2024 •
edited
Loading

Changes

feat: #8265

Scripts are often long and hard to read. When checking variable references, put non-existent variables before the message to make it easier to read.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

improve step.Script variables references validation message

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 2, 2024
@chengjoey
Copy link
Member Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 2, 2024
@chengjoey
Copy link
Member Author

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@chengjoey: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/substitution/substitution.go 87.0% 86.0% -0.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/substitution/substitution.go 87.0% 86.0% -0.9

@chengjoey
Copy link
Member Author

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@chengjoey: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chengjoey chengjoey force-pushed the feat/script-validation branch from c4e32f3 to b8bd1e2 Compare October 4, 2024 04:57
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/substitution/substitution.go 87.0% 87.6% 0.6

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/substitution/substitution.go 87.0% 87.6% 0.6

@chengjoey
Copy link
Member Author

/test pull-tekton-pipeline-alpha-integration-tests

@vdemeester
Copy link
Member

/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2024
@jkhelil
Copy link
Member

jkhelil commented Nov 19, 2024

/test pull-tekton-pipeline-go-coverage-df

@tekton-robot
Copy link
Collaborator

@jkhelil: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/substitution/substitution.go 87.0% 87.6% 0.6

@l-qing
Copy link
Contributor

l-qing commented Jan 3, 2025

Well done!
Finally, I don't have to check one by one who left it undefined.
I really hope we can merge this PR soon.

@chengjoey
Copy link
Member Author

/retest

@chengjoey
Copy link
Member Author

/test all

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/substitution/substitution.go 87.0% 87.6% 0.6

@chengjoey chengjoey force-pushed the feat/script-validation branch from b8bd1e2 to 1baa031 Compare January 6, 2025 02:09
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/substitution/substitution.go 87.0% 87.6% 0.6

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/substitution/substitution.go 87.0% 87.6% 0.6

@chengjoey
Copy link
Member Author

@afrittoli ,Are you available right now, can you review this pr?

@chengjoey
Copy link
Member Author

@l-qing Would you like to join the organization as a member?
https://github.com/tektoncd/community/tree/main/org

afrittoli
afrittoli reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@tekton-robot tekton-robot merged commit be2f28f into tektoncd:main Jan 9, 2025
17 checks passed
@l-qing
Copy link
Contributor

l-qing commented Jan 12, 2025

@l-qing Would you like to join the organization as a member? https://github.com/tektoncd/community/tree/main/org

Thank you for bringing this opportunity to my attention.

I had never considered the possibility of joining this organization before, but I'm genuinely excited about the prospect of becoming a member.

Upon reviewing the membership requirements, I noticed I still have some areas to work on. While I'm proud to have contributed with over 30 merged PRs, I realize I haven't participated in reviewing others' contributions. I mistakenly assumed that PR reviews were limited to existing members - I now see how wrong I was about that! 😄

I'm committed to meeting all the requirements and look forward to submitting my membership application in 2025.

@chengjoey
Copy link
Member Author

While I'm proud to have contributed with over 30 merged PRs

you've done a great job, and I very much welcome you to become a member. you can submit a PR to community, I think this can be done through

@l-qing
Copy link
Contributor

l-qing commented Jan 13, 2025

While I'm proud to have contributed with over 30 merged PRs

you've done a great job, and I very much welcome you to become a member. you can submit a PR to community, I think this can be done through

Thank you for your encouragement.

I still intend to wait until all the requirements are met before initiating the PR request, to avoid wasting others' review time.

I will prioritize this matter as the most important thing in the next three months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@vdemeester vdemeester vdemeester approved these changes

@abayer abayer Awaiting requested review from abayer

Assignees

@afrittoli afrittoli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chengjoey @tekton-robot @vdemeester @jkhelil @l-qing @afrittoli