-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancel PipelineRun only after its children Tasks are stopped #8141
Cancel PipelineRun only after its children Tasks are stopped #8141
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
/test all |
@renzodavid9: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The following is the coverage report on the affected files.
|
c77de5b
to
010cf70
Compare
The following is the coverage report on the affected files.
|
010cf70
to
77eb56b
Compare
The following is the coverage report on the affected files.
|
Fixes: #8031
Changes
With this change, when a PipelineRun is marked as
Cancelled
, it will first patch its children Tasks asCancelled
, and only after all of them report they were stopped, the PipelineRun will mark itself asCancelled
.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes