Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document failureIgnored #8111

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

pritidesai
Copy link
Member

@pritidesai pritidesai commented Jul 10, 2024

Changes

Document the status when a taskRun fails but the failure is ignored i.e. it has onError set to continue.

 k get tr pipelinerun-with-failing-task-bgl28-echo-continue -o json | jq .status.conditions
[
  {
    "lastTransitionTime": "2024-07-10T05:27:06Z",
    "message": "\"step-write\" exited with code 1",
    "reason": "FailureIgnored",
    "status": "False",
    "type": "Succeeded"
  }
]

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Document the status when a taskRun fails but the failure is ignored with
onError set to countinue.

Signed-off-by: Priti Desai <[email protected]>
@tekton-robot tekton-robot added kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesnt merit a release note. labels Jul 10, 2024
@tekton-robot tekton-robot requested review from abayer and dibyom July 10, 2024 23:29
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 10, 2024
@tekton-robot
Copy link
Collaborator

The following Tekton test failed:

Test name Commit Details Required Rerun command
check-pr-has-kind-label d53c49e link true /test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2024
@dibyom
Copy link
Member

dibyom commented Jul 11, 2024

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2024
@pritidesai
Copy link
Member Author

/retest

@tekton-robot tekton-robot merged commit e6bdc1c into tektoncd:main Jul 15, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants