Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Matrix Validation for non Matrix Pipelines #8088

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disable Matrix Validation for non Matrix Pipelines #8088

wants to merge 1 commit into from

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Jul 1, 2024 •
edited
Loading

This disables the Matrix Validation for Results in non Matrixed Pipelines.
This ensures that the controller doesn't encounter any crash or such for these pipelines as it
did at issue #8086

Fixes #8086

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 1, 2024
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 1, 2024
khrm
khrm commented Jul 1, 2024
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 1, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 91.7% -7.5

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 91.7% -7.5

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 92.2% -7.1

@khrm khrm changed the title [WIP] Fix Crash due to Matrix Validation in non Matrix Pipeline Fix Crash due to Matrix Validation in non Matrix Pipeline Jul 2, 2024
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2024
@khrm
Copy link
Contributor Author

khrm commented Jul 2, 2024

/retest

@khrm khrm changed the title Fix Crash due to Matrix Validation in non Matrix Pipeline [WIP] Fix Crash due to Matrix Validation in non Matrix Pipeline Jul 2, 2024
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2024
@khrm
Copy link
Contributor Author

khrm commented Jul 3, 2024

Are tests failing due to WIP?

@khrm khrm changed the title [WIP] Fix Crash due to Matrix Validation in non Matrix Pipeline Fix Crash due to Matrix Validation in non Matrix Pipeline Jul 3, 2024
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2024
@khrm
Copy link
Contributor Author

khrm commented Jul 3, 2024

/retest

vdemeester
vdemeester requested changes Jul 3, 2024
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khrm can we have a regression test ? For example, having the reproducer posted in the issue (or something simpler) in the example tests ?

@khrm
Copy link
Contributor Author

khrm commented Jul 3, 2024

@vdemeester Sure. I am adding that.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.0% -0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.0% -0.2

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jeromeju after the PR has been reviewed.
You can assign the PR to them by writing /assign @jeromeju in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.0% -0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.0% -0.2

@khrm
Copy link
Contributor Author

khrm commented Jul 3, 2024

@vdemeester I have added one regression test.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.0% -0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.0% -0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.0% -0.2

@khrm khrm changed the title Fix Crash due to Matrix Validation in non Matrix Pipeline Disable Matrix Validation for non Matrix Pipelines Jul 4, 2024
@khrm
Disable Matrix Validation for non Matrix Pipelines
6f60d06 
This disables the Matrix Validation for Results in non Matrixed Pipelines.
This ensures that the controller doesn't encounter any crash or such for these pipelines as it
did at issue tektoncd#8086

Fixes tektoncd#8086
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.0% -0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.0% -0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% 0.0

vdemeester
vdemeester reviewed Jul 5, 2024
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khrm any reason for the regression test to be in the upgrade tests and not in the exemples tests ?

@khrm
Copy link
Contributor Author

khrm commented Jul 19, 2024 •
edited
Loading

@vdemeester Examples aren't run as upgrade tests. We need a more complex pipeline for upgrade tests.

@afrittoli
Copy link
Member

#8086 is marked as closed by #8089, but this is meant to fix the same issue. Do we need to reopen #8086, was the fix incomplete?

@khrm
Copy link
Contributor Author

khrm commented Jul 31, 2024

@afrittoli I would say it's a partial fix. Error can happen in some other flow also.

@afrittoli afrittoli added this to the Pipeline v0.64 milestone Sep 23, 2024
@afrittoli
Copy link
Member

@vdemeester Examples aren't run as upgrade tests. We need a more complex pipeline for upgrade tests.

I think @vdemeester question was about why did you modify the upgrade test instead of the regular integration test.

@afrittoli afrittoli removed this from the Pipeline v0.66 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg left review comments

@vdemeester vdemeester vdemeester requested changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Controller crashes for certain Pipeline after upgrade
5 participants
@khrm @tekton-robot @afrittoli @vdemeester @piyush-garg