Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Identify workspace usage in a Task #8016

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Fix: Identify workspace usage in a Task #8016

merged 1 commit into from
Jun 4, 2024

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Jun 4, 2024 •
edited
Loading

Prior to this, when identifying whether a Task used a workspace, we limited the check to command, args and scripts in steps, stepTemplates and sidecars. This was done to propagate workspaces into the Tasks that use it instead of blindly propagating it to all the Tasks. However, the workspace path can also be used as a param to a StepAction or env cariables in steps and sidecars and also workingDirs. This PR fixes that.

Fixes #8008.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Fix: Identify workspace usage in a Task

/kind bug

@chitrangpatel
Fix: Identify workspace usage in a Task
3c9a1fd 
Prior to this, when identifying whether a Task used a workspace,
we limited the check to command, args and scripts in steps,
stepTemplates and sidecars. However, the workspace path could also
be used as a param to a StepAction or env cariables in steps and
sidecars and also workingDirs. This PR fixes that.

Fixes tektoncd#8008.
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2024
@tekton-robot tekton-robot requested review from bobcatfish and dibyom June 4, 2024 15:56
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspace/apply.go 98.2% 97.8% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspace/apply.go 98.2% 97.8% -0.4

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2024
@chitrangpatel
Copy link
Contributor Author

chitrangpatel commented Jun 4, 2024 •
edited
Loading

/cherry-pick release-0.59.x

@tekton-robot
Copy link
Collaborator

@chitrangpatel: once the present PR merges, I will cherry-pick it on top of release-0.59.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.59.x
/cherry-pick release-0.56.x
/cherry-pick release-0.53.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chitrangpatel
Copy link
Contributor Author

/cherry-pick release-0.56.x

@tekton-robot
Copy link
Collaborator

@chitrangpatel: once the present PR merges, I will cherry-pick it on top of release-0.56.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.56.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chitrangpatel
Copy link
Contributor Author

/cherry-pick release-0.53.x

@tekton-robot
Copy link
Collaborator

@chitrangpatel: once the present PR merges, I will cherry-pick it on top of release-0.53.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.53.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeromeJu, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JeromeJu,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JeromeJu
Copy link
Member

JeromeJu commented Jun 4, 2024

/lgtm thanks for the fix

@JeromeJu
Copy link
Member

JeromeJu commented Jun 4, 2024

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024
@tekton-robot tekton-robot merged commit 7ac2ca6 into tektoncd:main Jun 4, 2024
11 of 12 checks passed
@tekton-robot
Copy link
Collaborator

@chitrangpatel: cannot checkout release-0.59.x: error checking out release-0.59.x: exit status 1. output: error: pathspec 'release-0.59.x' did not match any file(s) known to git

In response to this:

/cherry-pick release-0.59.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

@chitrangpatel: cannot checkout release-0.56.x: error checking out release-0.56.x: exit status 1. output: error: pathspec 'release-0.56.x' did not match any file(s) known to git

In response to this:

/cherry-pick release-0.56.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

@chitrangpatel: cannot checkout release-0.53.x: error checking out release-0.53.x: exit status 1. output: error: pathspec 'release-0.53.x' did not match any file(s) known to git

In response to this:

/cherry-pick release-0.53.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JeromeJu
Copy link
Member

JeromeJu commented Jun 4, 2024

/cherry-pick release-v0.59.x
/cherry-pick release-v0.56.x
/cherry-pick release-v0.53.x

@tekton-robot tekton-robot mentioned this pull request Jun 4, 2024
Merged
@tekton-robot
Copy link
Collaborator

@JeromeJu: new pull request created: #8017

In response to this:

/cherry-pick release-v0.59.x
/cherry-pick release-v0.56.x
/cherry-pick release-v0.53.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JeromeJu
Copy link
Member

JeromeJu commented Jun 4, 2024

/cherry-pick release-v0.56.x

@JeromeJu
Copy link
Member

JeromeJu commented Jun 4, 2024

/cherry-pick release-v0.53.x

@tekton-robot tekton-robot mentioned this pull request Jun 4, 2024
Merged
@tekton-robot
Copy link
Collaborator

@JeromeJu: new pull request created: #8018

In response to this:

/cherry-pick release-v0.56.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

@JeromeJu: new pull request created: #8019

In response to this:

/cherry-pick release-v0.53.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Jun 4, 2024
Closed
@chitrangpatel chitrangpatel mentioned this pull request Jun 4, 2024
Merged
8 tasks
@chitrangpatel
Copy link
Contributor Author

/cherry-pick release-v0.60.x

@tekton-robot
Copy link
Collaborator

@chitrangpatel: new pull request created: #8021

In response to this:

/cherry-pick release-v0.60.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeromeJu JeromeJu JeromeJu approved these changes

@vdemeester vdemeester vdemeester approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@JeromeJu JeromeJu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing substitution of propagated workspace in WorkingDirs
4 participants
@chitrangpatel @tekton-robot @JeromeJu @vdemeester